feat: Pi.map rename to Function.map#39233
Open
linesthatinterlace wants to merge 9 commits into
Open
Conversation
PR summary 52e99ade9e
|
| File | Base Count | Head Count | Change |
|---|---|---|---|
| Mathlib.Logic.Function.Defs | 57 | 58 | +1 (+1.75%) |
Import changes for all files
| Files | Import difference |
|---|---|
Mathlib.Logic.Function.Defs Mathlib.Logic.Relator |
1 |
Declarations diff
+ Pi.map
+ Pi.map_apply
+ Pi.map_comp_map
+ Pi.map_id
+ Pi.map_id'
+ Pi.map_injective
+ Pi.map_iterate
+ Pi.map_update
+ map_const
+ map_def
+ map_injective
+ map_update
- _root_.Pi.map_injective
- _root_.Pi.map_update
You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>
## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.
No changes to strong technical debt.
No changes to weak technical debt.
linesthatinterlace
changed the title
Pi.map rename to Function.map
eric-wieser
added
the
awaiting-zulip
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR renames
Pi.maptoFunction.mapand makes the changes necessary to support this. In particular this means that Mathlib.Logic.Function.Defs now only contains the Function namespace.Zulip thread: #PR reviews > #39233 - rename Pi.map to Function.map @ 💬